robusta icon indicating copy to clipboard operation
robusta copied to clipboard

Feature Request: Add JSON logging to Robusta Runner

Open otherguy opened this issue 1 year ago • 9 comments

We use Kibana for logs and use structured JSON logs where possible.

It would be great if the runner could be configured to emit JSON logs.

otherguy avatar Aug 22 '23 10:08 otherguy

H, Tomer from the Robusta team here, we looked into it and have a proposed solution. Writing it down here so it is visible for contributors.

  1. Json logging should be done via the https://github.com/madzak/python-json-logger library
  2. Json logging should be optional. The user should opt-in for json logging by setting a variable to his generated_values.yaml file: json_logging: true

Sheeproid avatar Oct 31 '23 13:10 Sheeproid

@Sheeproid sounds good to me!

otherguy avatar Dec 12 '23 11:12 otherguy

@Sheeproid I would love work on this issue Can you assign it to me

itsCheithanya avatar Dec 20 '23 08:12 itsCheithanya

@pavangudiwada did you already create a POC for this?

aantn avatar Dec 20 '23 10:12 aantn

@aantn Yep, here's the code https://github.com/robusta-dev/robusta/commit/3e35fb1c44fe200b450b726bd970b8cc6b7215dc. Just need some tweaking and testing.

pavangudiwada avatar Dec 20 '23 10:12 pavangudiwada

@pavangudiwada Could you guide me on what needs to be done on my end so that I may begin?

itsCheithanya avatar Dec 20 '23 13:12 itsCheithanya

@itsCheithanya I might get to this in the next week or sooner. Happy to help if you have other issues that interest you.

pavangudiwada avatar Dec 22 '23 06:12 pavangudiwada

I would love to work on any of good first issues

itsCheithanya avatar Dec 28 '23 14:12 itsCheithanya

@pavangudiwada any progress on that?

otherguy avatar Feb 09 '24 10:02 otherguy