krr 1.17.0 install and upgrade with brew on MacOS reports libpng linkage errors

[stevo-f3]

Describe the bug

$ brew install krr
==> Fetching robusta-dev/krr/krr
==> Downloading https://github.com/robusta-dev/krr/releases/download/v1.17.0/krr-macos-latest-v1.17.0.zip
Already downloaded: /Users/foo/Library/Caches/Homebrew/downloads/8aa8a314f56ceb953f2a40c046d4b7c707532a6fbf6cc70fc660b28de881f4c3--krr-macos-latest-v1.17.0.zip
==> Installing krr from robusta-dev/krr
==> Running 'krr version' to warm up binary and extract compressed python libraries... this can take up to 60 seconds
==> /opt/homebrew/Cellar/krr/1.17.0/libexec/krr version
Error: Failed changing dylib ID of /opt/homebrew/Cellar/krr/1.17.0/libexec/_internal/PIL/.dylibs/libpng16.16.dylib
  from @rpath/libpng16.16.dylib
    to /opt/homebrew/opt/krr/libexec/_internal/PIL/.dylibs/libpng16.16.dylib
Error: Failed to fix install linkage
The formula built, but you may encounter issues using it or linking other
formulae against it.
...

To Reproduce Steps to reproduce the behavior:

1. Install or upgrade krr to 1.17.0 on MacOS

Expected behavior krr to install or upgrade with brew without errors

Screenshots N/A

Are you interested in contributing a fix for this? no

Desktop (please complete the following information):

• OS: MacOS Sonoma 14.7.1
• Browser: N/A
• Version: 1.17.0

Smartphone (please complete the following information): N/A

Additional context

[xxzk]

Got error when doing brew install krr, too.

❯ brew install krr
==> Downloading https://formulae.brew.sh/api/formula.jws.json
############################################################################################################################################################################################################ 100.0%
==> Downloading https://formulae.brew.sh/api/cask.jws.json
############################################################################################################################################################################################################ 100.0%
==> Fetching robusta-dev/krr/krr
==> Downloading https://github.com/robusta-dev/krr/releases/download/v1.17.0/krr-macos-latest-v1.17.0.zip
Already downloaded: /Users/bar/Library/Caches/Homebrew/downloads/8aa8a314f56ceb953f2a40c046d4b7c707532a6fbf6cc70fc660b28de881f4c3--krr-macos-latest-v1.17.0.zip
==> Installing krr from robusta-dev/krr
==> Running 'krr version' to warm up binary and extract compressed python libraries... this can take up to 60 seconds
==> /usr/local/Cellar/krr/1.17.0/libexec/krr version
Last 15 lines from /Users/bar/Library/Logs/Homebrew/krr/01.krr:
2024-11-08 00:56:38 +0000

/usr/local/Cellar/krr/1.17.0/libexec/krr
version


If reporting this issue please do so at (not Homebrew/brew or Homebrew/homebrew-core):
  https://github.com/robusta-dev/homebrew-krr/issues

These open issues may also help:
Cannot upgrade krr to version 1.10.0 https://github.com/robusta-dev/homebrew-krr/issues/4

MacOS 13.7.1

[minkbear]

same error here

❯ brew reinstall krr                                                                      
==> Fetching robusta-dev/krr/krr
==> Downloading https://github.com/robusta-dev/krr/releases/download/v1.23.0/krr-macos-latest-v1.23.0.zip
Already downloaded: /Users/mb/Library/Caches/Homebrew/downloads/c5310313799b61cd404eca43702b6c147366c4e47cf2ce95defc136a703ae3e2--krr-macos-latest-v1.23.0.zip
==> Reinstalling robusta-dev/krr/krr
==> Running 'krr version' to warm up binary and extract compressed python libraries... this can take up to
==> /opt/homebrew/Cellar/krr/1.23.0/libexec/krr version
Error: Failed changing dylib ID of /opt/homebrew/Cellar/krr/1.23.0/libexec/_internal/PIL/.dylibs/libpng16.16.dylib
  from @rpath/libpng16.16.dylib
    to /opt/homebrew/opt/krr/libexec/_internal/PIL/.dylibs/libpng16.16.dylib
Error: Failed to fix install linkage
Updated load commands do not fit in the header of /opt/homebrew/Cellar/krr/1.23.0/libexec/_internal/PIL/.dylibs/libpng16.16.dylib. /opt/homebrew/Cellar/krr/1.23.0/libexec/_internal/PIL/.dylibs/libpng16.16.dylib needs to be relinked, possibly with -headerpad or -headerpad_max_install_names
The formula built, but you may encounter issues using it or linking other
formulae against it.
==> Summary
🍺  /opt/homebrew/Cellar/krr/1.23.0: 2,707 files, 194.7MB, built in 34 seconds
==> Running `brew cleanup krr`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).

MacOS 15.2 (arm)

[BeyondEvil]

Same

❯ brew install krr
==> Fetching robusta-dev/krr/krr
==> Downloading https://github.com/robusta-dev/krr/releases/download/v1.23.0/krr-macos-latest-v1.23.0.zip
==> Downloading from https://objects.githubusercontent.com/github-production-release-asset-2e65be/603117527/334f1315-3614-454b-a7b2-df1db18c3d6f?X-Amz-Algorithm=A
########################################################################################################################################################### 100.0%
==> Installing krr from robusta-dev/krr
==> Running 'krr version' to warm up binary and extract compressed python libraries... this can take up to 60 seconds
==> /opt/homebrew/Cellar/krr/1.23.0/libexec/krr version
Error: Failed changing dylib ID of /opt/homebrew/Cellar/krr/1.23.0/libexec/_internal/PIL/.dylibs/libpng16.16.dylib
  from @rpath/libpng16.16.dylib
    to /opt/homebrew/opt/krr/libexec/_internal/PIL/.dylibs/libpng16.16.dylib
Error: Failed to fix install linkage
Updated load commands do not fit in the header of /opt/homebrew/Cellar/krr/1.23.0/libexec/_internal/PIL/.dylibs/libpng16.16.dylib. /opt/homebrew/Cellar/krr/1.23.0/libexec/_internal/PIL/.dylibs/libpng16.16.dylib needs to be relinked, possibly with -headerpad or -headerpad_max_install_names
The formula built, but you may encounter issues using it or linking other
formulae against it.
==> Summary
🍺  /opt/homebrew/Cellar/krr/1.23.0: 2,707 files, 194.7MB, built in 22 seconds
==> Running `brew cleanup krr`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).

[aantn]

For the Mac OS users, does this actually fail the installation? It seems to be a fatal warning, but at least on my machine it doesn't actually prevent KRR from installing and running.

[BeyondEvil]

@aantn it appears krr works, but I don't know what that lib does or how the failure would affect krr.

[aantn]

@BeyondEvil it seems to be a transitive dependency we don't actually use. (libpng is a dependency of PIL which itself is a dependency of matplotlib, which itself is a dependency of numpy, I think which we do use.).

[aantn]

We should fix regardless, but I don't think this actually breaks anything.

[BeyondEvil]

libpng is a dependency of PIL which itself is a dependency of matplotlib, which itself is a dependency of numpy, I think which we do use.

😅

[BK-STAR77]

Same

v1.27.0