krr icon indicating copy to clipboard operation
krr copied to clipboard

Published 20 hours ago • verified publisher icon robusta-dev

fix: allow overriding mimir headers

Open davidspek opened this issue 1 year ago • 1 comments

When connecting to Mimir the X-Scope-OrgID: anonymous tenant header is automatically set. However, when using the --prometheus-headers flag to set a custom value for this it isn't propagated. This change ensures that headers set through the cli flags overwrite any additional_headers specified in the code.

davidspek avatar Aug 29 '24 07:08 davidspek

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 29 '24 07:08 CLAassistant

When can we expect this fix to be merged? Currently this is blocking mimir instances that don't use anonymous from working at all.

chris-parker-za avatar Feb 07 '25 08:02 chris-parker-za

@chris-parker-za thank you for bumping this. Its merged and will be included in the next release.

aantn avatar Feb 07 '25 13:02 aantn

Happy to help! Glad it's approved finally.

chris-parker-za avatar Feb 07 '25 13:02 chris-parker-za