krr icon indicating copy to clipboard operation
krr copied to clipboard

Ability to aggregate multiple StatefulSets together

Open jdheyburn opened this issue 1 year ago • 1 comments

Is your feature request related to a problem? Please describe. My application is sharded across multiple StatefulSets, named as:

app-shard-1
app-shard-2
app-shard-3

Each of these shards/StatefulSets is made up of 3 pods.

Currently krr will aggregate the 3 pods in a StatefulSet into one recommendation. It would be helpful if krr allowed all of the pods in these StatefulSets (of which all share a common label) to be aggregated into one result.

Describe the solution you'd like A setting which will consolidate the results of the pods found into a single result.

Describe alternatives you've considered Setting --formatter json/yaml and parsing the results for the highest recommended memory value out of the results.

Additional context N/A

jdheyburn avatar Oct 06 '23 14:10 jdheyburn

This is actually a good idea

The only concern is what to do in a general case, if at a moment there were 2 pods, then only 1 and then back to 2? I don't think that in general case it would be logical to consider 2nd pod's two appearances as one (and calculate considering them both)? In terms of sharding a database - it should be.

Maybe also a good idea is to add something like --ungroup-pods flag, that will split each pod into it's separate calculation

LeaveMyYard avatar Oct 09 '23 14:10 LeaveMyYard