krr icon indicating copy to clipboard operation
krr copied to clipboard

Pods are not found

Open alexanderniebuhr opened this issue 2 years ago • 13 comments

Describe the bug We do have Pods which are created by another Pod (GitLab Runner Kubernetes Executer). These Pods don't have a Deployment, but even while they are running, they are not found in krr.

How can these Pods also be checked.

Screenshots If applicable, add screenshots to help explain your problem. Screenshot 2023-08-31 at 21 18 40

alexanderniebuhr avatar Aug 31 '23 19:08 alexanderniebuhr

I have a similar issue where pods are controlled by a service as opposed to a Deployment/StatefulSet/DaemonSet etc. It would be great if such pods could also be included in the result set.

obrienrobert avatar Aug 31 '23 22:08 obrienrobert

Hey! So, when starting this project we descided to skip recommendations for standalone pods But if you guys ask, I think this is time to add this feature

LeaveMyYard avatar Sep 01 '23 07:09 LeaveMyYard

We are also missing CronJob & Job

alexanderniebuhr avatar Sep 01 '23 08:09 alexanderniebuhr

@alexanderniebuhr Jobs should work as expected, but CronJobs we haven't added also Will add those for future tasks

LeaveMyYard avatar Sep 04 '23 14:09 LeaveMyYard

Thank you so much for this fantastic tool!

I was wondering today why the github runner wasn't showing up and then found this issue. This is probably related to that right?

mrclrchtr avatar Aug 15 '24 08:08 mrclrchtr

@mrclrchtr can you try running krr with the prometheus-workload-loader branch and see if they show up there?

aantn avatar Aug 15 '24 10:08 aantn

I tried the prometheus-workload-loader branch and unfortunately it doesn't show up.

mrclrchtr avatar Aug 15 '24 10:08 mrclrchtr

The LimitRange is other case, so the deployments aren't have Resources values and leave them to shared/common values in LimitRange, but pods have requests and krr does not consider it. View with pods should help.

lictw avatar Sep 12 '24 23:09 lictw