holmesgpt icon indicating copy to clipboard operation
holmesgpt copied to clipboard

fixing helm build failure

Open saurabh-arios opened this issue 3 months ago • 2 comments

Fixed helm failure according to https://github.com/helm/helm-www/pull/1750/files Current implementation fails on my M1 Mac with arm architecture

saurabh-arios avatar Sep 12 '25 21:09 saurabh-arios

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 12 '25 21:09 CLAassistant

Walkthrough

The Dockerfile switches Helm installation from an inline script to APT-based installation via the official Helm repository. It removes Kubernetes release verification environment variables, installs Helm in the builder stage, and copies the binary to the final image with updated paths and permissions.

Changes

Cohort / File(s) Summary
Docker build and tooling adjustments
Dockerfile
- Remove ENV VERIFY_CHECKSUM and VERIFY_SIGNATURES in builder stage
- Add Helm APT key and repo; install helm via apt
- Clean apt lists post-install
- Install Helm to /usr/bin/helm (builder) and copy to /usr/local/bin/helm (final)
- Retain chmod and helm --version execution

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Dev as Docker Builder (Stage 1)
  participant APT as APT Repos
  participant Final as Final Image (Stage 2)

  Dev->>APT: Add Helm GPG key and repo
  Dev->>APT: apt-get update
  Dev->>APT: apt-get install helm
  Note right of Dev: Helm installed at /usr/bin/helm

  Dev-->>Final: COPY /usr/bin/helm -> /usr/local/bin/helm
  Final->>Final: chmod +x /usr/local/bin/helm
  Final->>Final: helm --version

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • robusta-dev/holmesgpt#934: Similar Dockerfile changes replacing script-based Helm install with APT and adjusting binary copy paths.

Suggested reviewers

  • Sheeproid

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title directly describes the primary purpose of the changeset — resolving a Helm build failure. The raw_summary and PR objectives show the main changes replace an inline Helm installer with an apt-based installation and address ARM/M1 build issues, which the title references. Therefore the title is related and sufficiently summarizes the primary change for reviewers scanning history.
Description Check ✅ Passed The PR description states it fixes a Helm build failure, links to the upstream change, and notes the issue occurs on M1/ARM, which aligns with the Dockerfile changes and PR objectives that switch Helm installation to apt and remove verification flags. This makes the description relevant to the changeset and not off-topic, so it passes the lenient description check. The description could be expanded with file-level notes and the CLA status to better assist reviewers.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

[!TIP]

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

✨ Finishing touches
🧪 Generate unit tests
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Sep 12 '25 21:09 coderabbitai[bot]