robust icon indicating copy to clipboard operation
robust copied to clipboard

Tested full process of bugzoo container creation

Open Chamango90 opened this issue 6 years ago • 10 comments

Harsh and I today tried the whole robust process (with ac6a181). We can talk about it on Wednesday`s meeting. All in all it worked quite good but still we found some "issues".

Issues with time machine

./docker/build.sh # Fails
cd docker && ./build.sh # Works 

It is important to be inside the docker folder. One could either fix this or write the steps in the instructions to avoid problems for potential users.

Issues with bugzoo (@ChrisTimperley )

Note: This script assumes that the rosinstall_generator_time_machine binary is visible from the PATH.

Maybe more info about "add rosinstall_generator_time_machine to path" (confusing cause I do not see the “binary”?)


$ python scripts/build-rosinstall.py mavros/08cd181.bug (https://github.com/robust-rosin/robust/tree/master/scripts)

should be 08cd181/08cd181.bug


Add in the instructions that one has to create a test.sh file.


latest bugzoo 2.1.25 is failing.


fork-urls: without s? (https://github.com/robust-rosin/robust/tree/master/scripts)


fork-url cannot handle a list

Step 5/43 : RUN echo "[ROBUST] cloning repo: '${REPO_FORK_URL}'"  && git clone "${REPO_FORK_URL}" /tmp/repo-under-test  && echo "[ROBUST] cloned repo."
 ---> Running in 5507f593d234
[ROBUST] cloning repo: '['https://github.com/robust-rosin/cob_command_tools']'
Cloning into '/tmp/repo-under-test'...
fatal: I don't handle protocol '['https'

I think somewhere earlier though it would complain if it is not a list.


Questions:

  • how to stop bugzoo container?
  • How to delete bugzoo image that has been build?

Dockerfile

  File "/home/jfh/stuff_for_ros/bugzoo_venv/lib/python3.5/site-packages/bugzoo/mgr/container.py", line 222, in provision
    raise Exception(msg)  # TODO add exception; DockerException, maybe?
Exception: failed to start Docker container, 7416105e-f718-4cd6-b5fd-1e9ef93322f5:
  [RESPONSE]
      /entrypoint.sh: line 4: /ros_ws/devel/setup.bash: No such file or directory
  [/RESPONSE]

This means catkin_build failed.

Step 42/44 : RUN echo "[ROBUST] attempting to build PUT..."  && echo "[ROBUST] is a build failure expected? ${IS_BUILD_FAILURE}."  && ./build.sh || [ "${IS_BUILD_FAILURE}" = "yes" ]
 ---> Running in acfe3340c7c7
[ROBUST] attempting to build PUT...
[ROBUST] is a build failure expected? yes.
Error(s) in package '/ros_ws/src/repo-under-test/cob_teleop_cob4/package.xml':
The license tag must neither be empty nor only contain whitespaces

Base path: /ros_ws
Source space: /ros_ws/src
Build space: /ros_ws/build
Devel space: /ros_ws/devel
Install space: /ros_ws/install
Creating symlink "/ros_ws/src/CMakeLists.txt" pointing to "/opt/ros/hydro/share/catkin/cmake/toplevel.cmake"
 ---> 6e581e697565
Removing intermediate container acfe3340c7c7
Step 43/44 : COPY test.sh .
 ---> 30569d285e05

Build is failing because of missing license in:

https://github.com/ipa320/cob_command_tools/blob/89eb430617039f04c7c61ba0dae8b303c26fc048/cob_teleop_cob4/package.xml

--> How should we solve this?

TODOs for us (@ipa-jfh and @ipa-hsd)

  • [ ] fix fix hash to https://github.com/ipa320/cob_command_tools/commit/81aa175d76608fbac6655ce745e8eaa1d35f51f9#diff-a2b99615ad18e3db8af7eb5c52d6b8af
  • [ ] it is not a build bug
  • [ ] write test : rosrun cob_script_server cob_console

Chamango90 avatar Feb 18 '19 16:02 Chamango90