robtweed
fix jwt in native app for qewd up.
Fix where qewd up would not allow jwt support even if we add jwt in config.json file in case of native app .
I'm not going to make the suggested changes for two reasons: 1) I'm concerned that the CORS-related changes to Express headers and socket-io configuration could/may have negative consequences for other users; and 2) the versions of some of the modules you've made changes to are out of date compared with the QEWD Master version. I think the way to handle 1) would be to provide additional configuration settings via the config.json file and then conditionalise the code you suggest to use those specific configuration changes
Hi Rob, Sorry the new commit related to cors changes is accidently done. I was committing my public/private code present on my old laptop to make it available on the new laptop and accidentally committed the cors changes that I was just playing around with cors functions. The suggested changes were only for jwt for native apps.
Regards, Faisal
On Tue, Oct 26, 2021 at 1:31 PM robtweed @.***> wrote:
I'm not going to make the suggested changes for two reasons: 1) I'm concerned that the CORS-related changes to Express headers and socket-io configuration could/may have negative consequences for other users; and 2) the versions of some of the modules you've made changes to are out of date compared with the QEWD Master version. I think the way to handle 1) would be to provide additional configuration settings via the config.json file and then conditionalise the code you suggest to use those specific configuration changes
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/robtweed/qewd/pull/39#issuecomment-951708234, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADMJQUSUABMMRTLMA2HYCTUIZYOFANCNFSM4IOTIX3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.