Robert Stoll

Results 150 comments of Robert Stoll

And naming needs a decision, I saw that others use `key` instead of `property` (in the sense of key/value) and the ECMA standard refers to it as `name`. What should...

I guess something like using JsonPath to select a value/obj/array and make an assertion could be handy as well. No need to support that from the start though, if someone...

I would use JsonPath for retrieval, it could make assertions more readable in certain cases. Following an example: ``` assert(json).isJson { path("/store/book/author").contains("J. R. R. Tolkien", "F. Kafka") } ``` This...

Thanks for the hint about System.lineSeparator and the missing `been`. However, I prefer `used` over `expected`. I have update the description and added the missing `had`. I hope the sentence...

I see your point. The problem I see with `expected` is that it might not be that obvious could be confusing in the sense of: > Why does Atrium tell...

How about the following: ``` expect(person) { failFast = true its { firstName }.toBe("Ilya") its { lastName }.toBe("Fedorinov") } ``` where it does not matter where you place `failFast` within...

As info, I intend to improve `its` so that it will be able to show its content -- but at a later point. IMO this feature is not that crucial....

> How would you find out which stack trace entry to take? E.g. by creating an exception when creating the feature extraction. The bad thing about it, we would need...

> That is not my experience at all. I remember that logging libraries where not showing it. But I was surprised to see lately, that they are now including it...

One cannot define the type of the exception which should not occur, so no problem there. I am not yet convinced we need the renaming but you can try to...