atrium icon indicating copy to clipboard operation
atrium copied to clipboard

rewrite readme-examples/build.gradle to build.gradle.kts

Open robstoll opened this issue 3 years ago • 6 comments

Platform (all, jvm, js): all Extension (none, kotlin 1.3): none

Code related feature

Would be nicer to have the build file in Kotlin instead of groovy

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over. This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help (Invite yourself in case you do not have an account yet).

robstoll avatar Jun 27 '22 14:06 robstoll

Hey, @robstoll I'll work on this :)

Chandra-Sekhar-Bala avatar Jul 02 '22 11:07 Chandra-Sekhar-Bala

So, to be specific I need to replace "build.gradle" with "build.gradle.kts" in the README.MD file right @robstoll ?

Chandra-Sekhar-Bala avatar Jul 02 '22 14:07 Chandra-Sekhar-Bala

No, your task is to rewrite https://github.com/robstoll/atrium/blob/main/misc/tools/readme-examples/build.gradle (i e. currently groovy based) to build.gradle.kts (Kotlin based)

robstoll avatar Jul 02 '22 14:07 robstoll

Well I haven't worked on groovy yet. Can you please provide some resource to get this work done?

Chandra-Sekhar-Bala avatar Jul 03 '22 03:07 Chandra-Sekhar-Bala

@Chandra-Sekhar-Bala I suggest you read https://kotlinlang.org/docs/multiplatform-add-dependencies.html and similar sites and compare groovy and Kotlin. If you are already familiar with gradle's Kotlin DSL then just rename build.gradle to build.gradle.kts and start fixing the errors

robstoll avatar Jul 03 '22 06:07 robstoll

@Chandra-Sekhar-Bala do you need help?

robstoll avatar Jul 14 '22 07:07 robstoll

I'll do this

Kaustubh-Umbarkar avatar Sep 21 '22 12:09 Kaustubh-Umbarkar

hello @robstoll I would like to work on this issue.

DakshSuryavanshi avatar Oct 05 '22 07:10 DakshSuryavanshi

hello @robstoll just needed a confirmation, you basically want is that to change the extension of the file and solve the errors. and finally convert groovy to kotlin. Also i'm a bit new to groovy but well versed with kotlin so I'm really sorry for taking a bit longer than usual, i'll go through the resources given by you in the conversations above, hope those will be enough to know the basics.

DakshSuryavanshi avatar Oct 08 '22 19:10 DakshSuryavanshi

@DakshSuryavanshi you got it right. solving errors and migrate from groovy to kotlin is the same in this case. I don't think you need to read a lot of groovy stuff. Change the file extension and see what errors remain, the IDE will help you as well. And in case you are stuck, there are other build.gradle.kts in this project which have already been migrated

robstoll avatar Oct 09 '22 16:10 robstoll

@DakshSuryavanshi are you still working on that? If not, I can take it

jakubriegel avatar Oct 19 '22 14:10 jakubriegel

@jakubriegel IMO you can start with this, @DakshSuryavanshi can still try to come up with a PR on their own for learning purposes

robstoll avatar Oct 19 '22 20:10 robstoll

Cool 🚀 I'll make a PR in 2-3 days

jakubriegel avatar Oct 19 '22 20:10 jakubriegel