atrium icon indicating copy to clipboard operation
atrium copied to clipboard

add tests for reportOptions to MapToContainInOrderOnlyKeyValueExpectationsSpec

Open robstoll opened this issue 2 years ago • 10 comments

Platform (all, jvm, js): all Extension (none, kotlin 1.3): none

Code related feature

Following the things you need to do:

  • [ ] see TODOs in MapToContainInOrderOnlyKeyValueExpectationsSpec

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over. This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help (Invite yourself in case you do not have an account yet).

robstoll avatar Apr 24 '22 20:04 robstoll

Hi @robstoll ,

I'll work on this. I'm new to open source projects, so would you support me where to start?

simonNozaki avatar Jun 14 '22 03:06 simonNozaki

@simonNozaki sure, I guess you had already a look at Your first code contribution. Note that adding a sample would probably be an easier issue to start with and as you are new, I recommend you work on one of those: https://github.com/robstoll/atrium/issues?q=is%3Aopen+label%3A%22good+first+issue%22+sample

robstoll avatar Jun 14 '22 19:06 robstoll

@robstoll Thank you for your replying!

Note that adding a sample would probably be an easier issue to start with and as you are new

Yes, so I'll work on this: https://github.com/robstoll/atrium/issues/1045

simonNozaki avatar Jun 14 '22 22:06 simonNozaki

@robstoll , Thanks to assign me to this issue. Can I add some methods or utilities to the base class of MapToContainInOrderOnlyKeyValueExpectationsSpec , MapLikeToContainFormatSpecBase ?

IterableToContainSpecBase (the base class of IterableToContainInOrderOnlyValuesExpectationsSpec) has those, so I suppose that it's better to match its example.

simonNozaki avatar Jun 18 '22 11:06 simonNozaki

Sure go ahead

robstoll avatar Jun 18 '22 16:06 robstoll

Hi, @robstoll

I wrote the first spec in context, so how can I run specs? In locally, thgrough gradle, I ran ./gradlew :atrium-specs:jvmTest --info, but it seems that gradle could not look up test cases.

Though I checked wiki of this, repository, but I could not found the way to run.

simonNozaki avatar Jun 19 '22 12:06 simonNozaki

@simonNozaki specs only defines the specs in a parametric way. It's the tests of the Api modules you need to run in the end. easiest is you run ./gradlew build. If you want to be more specific, then run ./gradle :atrium-api-fluent-en_GB:test or :jvmTest

robstoll avatar Jun 19 '22 13:06 robstoll

@simonNozaki let me know in case you need help

robstoll avatar Jul 12 '22 20:07 robstoll

Sorry, in these days i was so busy in my company, so I could not commit to this issue...

simonNozaki avatar Jul 14 '22 13:07 simonNozaki

@simonNozaki no worries and no hurry, just wanted to be sure you are not stuck

robstoll avatar Jul 14 '22 13:07 robstoll