atrium icon indicating copy to clipboard operation
atrium copied to clipboard

add samples for sequenceSubjectChangers also to api-infix

Open robstoll opened this issue 2 years ago • 3 comments

Platform (all, jvm, js, android): all Extension (none, kotlin 1.3): none

Code related feature

We also want to provide samples for the infix api

Following the things you need to do:

  • [ ] copy SequenceSubjectChangerSamples from fluent-api to api-infix, adjust imports ...api.fluent... to ...api.infix... and adjust the samples accordingly (always use the infix syntax, never the fluent).
    • [ ] take a look at existing Samples (e.g. ListFeatureExtractorSamples) in api-infix for how to format comments
  • [ ] check that the sample in the KDoc Intellij is showing looks good (ALT+Mouse-click on function name)

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over. This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help (Invite yourself in case you do not have an account yet).

robstoll avatar Nov 04 '21 22:11 robstoll

I'll work on this

louetriTaha avatar Feb 06 '22 18:02 louetriTaha

@louetriTaha do you need help?

robstoll avatar Feb 21 '22 20:02 robstoll

@simonNozaki you need to add a comment if you want to tackle this. This way I can sign the issue to you

robstoll avatar Jun 18 '22 09:06 robstoll

Is this issue still available? I would be interested in giving it a go.

Edit: I'll work on this

JordanllHarper avatar Aug 21 '22 09:08 JordanllHarper

@JordanllHarper Yes, go ahead 👍

robstoll avatar Aug 22 '22 06:08 robstoll