pyangbind icon indicating copy to clipboard operation
pyangbind copied to clipboard

Update yangtypes.py for all upper case bool

Open tejaskumark opened this issue 6 years ago • 8 comments

Sometime user input could be all upper case bool value.

tejaskumark avatar Jan 10 '19 10:01 tejaskumark

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

googlebot avatar Jan 10 '19 10:01 googlebot

I signed it!

tejaskumark avatar Jan 10 '19 11:01 tejaskumark

Can someone help me understand why my merge is failing because of environement variable issue?

tejaskumark avatar Jan 25 '19 04:01 tejaskumark

@robshakir Can you please help me to get this issue past?

tejaskumark avatar Jan 25 '19 06:01 tejaskumark

@googlebot I signed it!

tejaskumark avatar Jan 25 '19 06:01 tejaskumark

CLAs look good, thanks!

googlebot avatar Jan 25 '19 06:01 googlebot

@tejaskumark The test failures are likely the ones which I encountered (and fixed) in #233. So once @robshakir gets that merged in, as long as you pull in the latest master branch, this should then pass.

tarkatronic avatar Jan 25 '19 16:01 tarkatronic

@robshakir Can you please help here with review for merge?

tejaskumark avatar Jun 03 '22 12:06 tejaskumark

Hi,

Could you please rebase to a recent versions of pyangbind ?

Thanks.

JoseIgnacioTamayo avatar Oct 13 '23 07:10 JoseIgnacioTamayo

Closing old PullRequest

JoseIgnacioTamayo avatar Dec 11 '23 19:12 JoseIgnacioTamayo