pyangbind icon indicating copy to clipboard operation
pyangbind copied to clipboard

Potential bugfix for #232

Open tarkatronic opened this issue 6 years ago • 2 comments

This is the proposed fix for #232 although I am still rather concerned that we don't have any tests which expose this reported issue.

I also had to do some small updates for the latest openconfig model changes.

And I included a minor version bump because, with this release, the xml serialization will be released as well!

tarkatronic avatar Dec 03 '18 16:12 tarkatronic

Codecov Report

Merging #233 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #233   +/-   ##
=======================================
  Coverage   71.37%   71.37%           
=======================================
  Files           7        7           
  Lines        1806     1806           
  Branches      484      484           
=======================================
  Hits         1289     1289           
  Misses        382      382           
  Partials      135      135

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 52e4693...b70c62e. Read the comment docs.

codecov[bot] avatar Dec 03 '18 16:12 codecov[bot]

I tested using the branch tarkatronic:issue-232, it does fix the issue mentioned in issue-232. Thanks!

kqchen34 avatar Dec 04 '18 13:12 kqchen34

Hi,

Could you please rebase to a recent versions of pyangbind ?

Thanks.

JoseIgnacioTamayo avatar Oct 13 '23 07:10 JoseIgnacioTamayo

Hi,

Could you please rebase to a recent versions of pyangbind ?

Thanks.

Hi @JoseIgnacioTamayo, I have not used pyangbind in many years now, and am therefore no longer involved in the development. If this is still found to be a useful bugfix, I would encourage you to take over this change. Thank you!

tarkatronic avatar Oct 13 '23 16:10 tarkatronic

https://github.com/robshakir/pyangbind/issues/232 was closed.

JoseIgnacioTamayo avatar Dec 11 '23 19:12 JoseIgnacioTamayo