pyangbind
pyangbind copied to clipboard
robshakir
fix a identityref field module name namespace missing issue.
the issue is: when load identityref field to Yang data tree with module name as the namespace, when we dump the Yang data to ietf json, the namespace will lost.
the root cause is: when we generate python code from Yang module, the restriction_arg for the field doesn't include module name as the prefix.
the fix is: add source_module into the imported_prefixes, so pyangbind can generate also generate the module name as the namespace for identityref field.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.
Codecov Report
Merging #220 into master will decrease coverage by
0.07%. The diff coverage is0%.
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
- Coverage 71.37% 71.29% -0.08%
==========================================
Files 7 7
Lines 1806 1808 +2
Branches 484 485 +1
==========================================
Hits 1289 1289
- Misses 382 384 +2
Partials 135 135
| Impacted Files | Coverage Δ | |
|---|---|---|
| pyangbind/helpers/identity.py | 0% <0%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 9aaf533...27c2631. Read the comment docs.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @xavier-contreras & @JoseIgnacioTamayo ,
I've hit the same issue, so I'd love to see this fix included in pyangbind :)
The following change adds a testcase that triggers the issue described by @guojunzhang : https://github.com/fperrin/pyangbind/commit/8f8a70e5c49acbb9bdcf506d8b1a832cda008d78. I can open a new PR, or you can merge this one and then commit that UT.
Hi,
Could you please rebase to a recent versions of pyangbind ?
@fperrin , feel free to propose a new PR with the change + tests.
Thanks.
@fperrin , feel free to propose a new PR with the change + tests.
Thanks.
Hi @JoseIgnacioTamayo , did just so, as #322 .