pyangbind icon indicating copy to clipboard operation
pyangbind copied to clipboard

Updates json ietf serialization to not prefix a property value that i…

Open markuscraig opened this issue 6 years ago • 2 comments

…s already prefixed. This can occur when ietf serializing an instance that was deserialized from a json ietf string. For example...

# deserialize from json-ietf
$ aps = pybindJSON.loads_ietf(OC_EXAMPLE_ACCESS_POINTS, openconfig_access_points, "openconfig_access_points")

# serialize to json-ietf
$ pybindJSON.dumps(aps, indent=None, mode='ietf')

markuscraig avatar Jun 15 '18 22:06 markuscraig

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

googlebot avatar Jun 15 '18 22:06 googlebot

Thanks Markus -- could you perhaps update this following the work that has been done in the serialisation code.

Also, if you or your organisation could sign the CLA -- that'd be great.

Thank you! r.

robshakir avatar Jun 16 '18 01:06 robshakir

Hi,

This PR has a merge conflict. I've opened https://github.com/robshakir/pyangbind/pull/313 with the same change + a testcase exhibiting the issue, against the lastest master trying to preserve authorship information. If #313 is merged, then this PR can be closed.

fperrin avatar Aug 14 '23 20:08 fperrin

PR #313, which contains this change plus a testcase, has been merged, so this PR can now be closed.

fperrin avatar Sep 04 '23 15:09 fperrin

PR https://github.com/robshakir/pyangbind/pull/313, which contains this change plus a testcase, has been merged, so this PR can now be closed.

JoseIgnacioTamayo avatar Oct 13 '23 07:10 JoseIgnacioTamayo