pynetworktables icon indicating copy to clipboard operation
pynetworktables copied to clipboard

Update rate does not match pyntcore

Open auscompgeek opened this issue 5 years ago • 5 comments
trafficstars

If pyntcore is installed, the default update rate will suddenly change, which I would expect nobody installing random packages would expect to happen. This also makes the docs inconsistent with pyntcore.

The following line needs to be changed to be every 100 ms instead:

https://github.com/robotpy/pynetworktables/blob/812e615d4e86858e5844ad9c1bc4015715f3bd76/_pynetworktables/_impl/dispatcher.py#L71

auscompgeek avatar Feb 07 '20 13:02 auscompgeek

In the meantime, if you would like your update rate to be consistent regardless of what packages are installed, you can use the NetworkTablesInstamce.setUpdateRate method.

Robot code always uses pyntcore, and so will always have a default update rate of 100 ms.

auscompgeek avatar Feb 07 '20 13:02 auscompgeek

I feel like we should change pyntcore's default to be 50ms?

virtuald avatar Feb 07 '20 16:02 virtuald

Given the performance issues we had last year, I'm not sure I'm comfortable with doubling down on the doubled update rate here.

auscompgeek avatar Feb 07 '20 21:02 auscompgeek

Well, it's almost 2022. Which way do we want to go? I'm still in favour of matching ntcore here.

auscompgeek avatar Dec 28 '21 13:12 auscompgeek

FIne.

virtuald avatar Dec 28 '21 15:12 virtuald