vanilla icon indicating copy to clipboard operation
vanilla copied to clipboard

Version number

Open schriftgestalt opened this issue 6 years ago • 16 comments

Is there a version number somewhere? If not, can we add one?

schriftgestalt avatar Apr 05 '18 10:04 schriftgestalt

there is https://github.com/typesupply/vanilla/blob/master/setup.py#L24 :) but not a good one...

typemytype avatar Apr 05 '18 14:04 typemytype

Something like:

import vanilla
print vanilla.__version__

would be nice.

schriftgestalt avatar Apr 05 '18 14:04 schriftgestalt

yes, what Georg proposes is standard for python modules.

but one can still get the version string from metadata that is installed along with a package, using pkg_resources (part of setuptools), like this:

from pkg_resources import get_distribution, DistributionNotFound
try:
    version = get_distribution("vanilla").version
except DistributionNotFound:
    # package is not installed, or is missing dist-info metadata
    ...

anthrotype avatar Apr 05 '18 14:04 anthrotype

I send a pull request. I set the version to 0.1, for now.

schriftgestalt avatar Apr 05 '18 14:04 schriftgestalt

On a second though, we could use an integer only version number (like firefox) as there are no releases. So we can just increment the number when there is a change and we don’t need to decide if it is a minor or major change.

schriftgestalt avatar Apr 05 '18 15:04 schriftgestalt

quick thought: the commit number is also fine for me..

typemytype avatar Apr 05 '18 15:04 typemytype

If that plays well with branches?

schriftgestalt avatar Apr 05 '18 15:04 schriftgestalt

if you want to use the same string for the setup.py version, then it should conform to the https://www.python.org/dev/peps/pep-0440/

Maybe you don't care at all about distributing vanilla via the normal python distribution channels for you only use it in embedded apps, in which case you're free to do whatever.

I personally prefer a PEP440-compatible SemVer style, to not break user expectations too much.

anthrotype avatar Apr 05 '18 15:04 anthrotype

FWIW in booleanOperations we use setuptools_scm, that computes the setup.py version automatically using git.

anthrotype avatar Apr 05 '18 15:04 anthrotype

Let's stick to a simple major.minor scheme. I also propose to call what we currently have 1.0 :)

justvanrossum avatar Apr 05 '18 15:04 justvanrossum

Agree. It's been around for long enough to be 1.0.

benkiel avatar Apr 05 '18 20:04 benkiel

hello from 2019 :)

let’s finally change the version number? in honor of the recent auto layout updates.

gferreira avatar Oct 24 '19 11:10 gferreira

+1 for a jump

typemytype avatar Oct 24 '19 13:10 typemytype

Agree! 1.0 it should be!

benkiel avatar Oct 24 '19 14:10 benkiel

And, we should put it on pipy, though there is a vanilla already there.

benkiel avatar Oct 24 '19 14:10 benkiel

And, we should put it on pipy, though there is a vanilla already there.

Pushing this a bit more. To get around the existing vanilla package, I would suggest a pip naming like vanilla-ui or vanilla-macos

form-follows-function avatar Jul 15 '20 22:07 form-follows-function