Use respondsToSelector instead of hasattr in _breakCycles.

Open typesupply opened this issue 2 years ago • 4 comments

This addresses #145.

Closing the test window in the issue goes from taking 0.11 seconds to 0.01 seconds.

Dec 20 '23 17:12 typesupply

@typemytype @justvanrossum Could one of you double check that I'm not making a mistake here. I'm 99% sure it is okay, but since this will affect every vanilla window ever, I'd like another pair of eyes on it.

Dec 20 '23 17:12 typesupply

looks fine! the callback should only be used with nsObject (vanilla contentViews)

approved +1

Dec 22 '23 11:12 typemytype