fontParts icon indicating copy to clipboard operation
fontParts copied to clipboard

FontParts Site - Object Tree missing "Groups"

Open colinmford opened this issue 5 years ago • 7 comments

Hey all,

I just realized the "object tree" found here is missing a "Groups" bubble coming off of "Font"... I guess it should go in that empty space next to "Features"?

Screen Shot 2020-08-03 at 3 12 26 PM

@arrowtype / @thundernixon I'm not sure how to edit the site to make a PR to fix this... Do I just edit this file?

https://github.com/robotools/fontParts/blob/master/documentation/source/_themes/fontPartsTheme/static/diagrams/fp-object-tree.svg

colinmford avatar Aug 03 '20 19:08 colinmford

Well spotted, Colin!

It’s been quite awhile since I touched the docs here, but yes, I think you would probably edit that SVG, and then you would probably also have to copy that updated SVG code into the raw HTML at:

https://github.com/robotools/fontParts/blob/master/documentation/source/objectref/objects/index.rst

arrowtype avatar Aug 03 '20 20:08 arrowtype

this is mentioned in the RoboFont 3.4 release. the map has been updated in the RF docs* and in FontParts map.

* http://gitlab.com/typemytype/robofont_com/-/blob/master/images/building-tools/fontPartsMap.svg

gferreira avatar Aug 03 '20 22:08 gferreira

@gferreira @typemytype Is it ok to use that RF Docs SVG you linked to replace the current one on the FontParts site?

@arrowtype once I update it, how would you recommend previewing the page to make sure it's correct? Do I need to rebuild the documentation from source locally?

colinmford avatar Aug 06 '20 19:08 colinmford

@colinmford yes, feel free to use it. you’ll just need to update the URLs and the font.

gferreira avatar Aug 07 '20 10:08 gferreira

FWIW, .groups and similar accessors should also be added to the documentation for the Font object.

simoncozens avatar Nov 04 '20 08:11 simoncozens

@simoncozens I am 100% likely missing it, but isn't it there: https://fontparts.robotools.dev/en/stable/objectref/objects/font.html#fontParts.base.BaseFont.groups ?

Let me know what I got wrong, it's been a day.

benkiel avatar Nov 04 '20 19:11 benkiel

I have no idea how I missed that. Sorry, as you were...

simoncozens avatar Nov 05 '20 11:11 simoncozens