Point _set_contour() shouldn't assert None

Open andyclymer opened this issue 7 years ago • 1 comments

It seems like this _set_contour() function shouldn't assert None in the first line:

https://github.com/robofab-developers/fontParts/blob/c09c388bacb2bfa70bbad2b3819552506f9e28ea/Lib/fontParts/base/point.py#L70-L74

Removing the first line of the function seems to make it work. However, which situations should someone be able to set a contour in this way? Where on the new contour would/should it add the point? It feels like this entire method should raise an AttributeError.

Thoughts?

Apr 08 '18 00:04 andyclymer

I did some digging and this is needed. See the _setContourInPoint method of BaseContour. Are you running into a situation in which that assertion is being raised?

Apr 12 '18 18:04 typesupply