photographer-io icon indicating copy to clipboard operation
photographer-io copied to clipboard

wrote pending tests - for review

Open dklounge opened this issue 11 years ago • 2 comments

Could use your help in reviewing some of the specs I wrote for the pending tests. The class spec is bit messy. Basically, I struggled to get the auth && auth.persisted? block to work. Initially, I tried stubbing outside of the context block initially,

auth.stub(:persisted?).and_return true

but that had no impact on auth object created using auth_hash, so ended up writing things out and calling update_attributes directly. Your thoughts?

dklounge avatar Jan 03 '14 08:01 dklounge

Coverage Status

Coverage remained the same when pulling 333a861cd6f827aa7509136a69631d9d6861ed6c on dklounge:authorisation_spec into 954af5ddc1aad2f34f2969cc55d0956d7017df56 on afternoonrobot:master.

coveralls avatar Jan 03 '14 08:01 coveralls

Thanks for this @dklounge! I've only got time to leave this comment tonight but I'll take a look at this over the weekend :)

robotmay avatar Jan 03 '14 20:01 robotmay