SeleniumLibrary icon indicating copy to clipboard operation
SeleniumLibrary copied to clipboard

fix `StringIO` import as it was removed in robot 5.0

Open DetachHead opened this issue 3 years ago • 3 comments

fixes #1752

DetachHead avatar Dec 05 '21 23:12 DetachHead

Assuming the failed CI has nothing to do with my change because the same is happening on every other open PR

DetachHead avatar Dec 06 '21 21:12 DetachHead

It's not, this is caused by a bug in ApprovalTests.Python.

aaltat avatar Dec 07 '21 05:12 aaltat

Ping @emanlove and @rasjani Approval test is causing problems, because of: https://github.com/approvals/ApprovalTests.Python/issues/103

Pinning the Approval test version should fix the problem.

aaltat avatar Dec 07 '21 09:12 aaltat

Just an update, in adding robotframework version 5.0.1 the acceptance tests were having some strange issues. Investigated those last weekend with no resolution and ran out of time. Going to pick this back up again. Either way this changes looks needed so I am going ahead and merge it in. This may break tests for a bit.

emanlove avatar Oct 15 '22 14:10 emanlove