SeleniumLibrary icon indicating copy to clipboard operation
SeleniumLibrary copied to clipboard

Update webdrivertools.py

Open remontees opened this issue 4 years ago • 5 comments

Support Edge webdriver for Linux.

remontees avatar Mar 09 '21 08:03 remontees

This breaks one of the unit tests, please fix it.

aaltat avatar Mar 09 '21 09:03 aaltat

This breaks one of the unit tests, please fix it.

For sure, because the test is already expecting the .exe file instead of the cross-platform executable: https://github.com/robotframework/SeleniumLibrary/blob/6025235f6b24b4843a753dc90fb4c2a814c27227/utest/test/keywords/test_webdrivercreator.py#L475

remontees avatar Mar 09 '21 13:03 remontees

@remontees Why do we need to update the code? Can you just specify the executable_path argument in the Open browser keyword as an example below?

Open Browser http://example.com Edge executable_path=msedgedriver

idxn avatar Mar 10 '21 15:03 idxn

Because then it by default will work with larger community.

aaltat avatar Mar 10 '21 15:03 aaltat

Because then it by default will work with larger community.

@idxn That's it: if you try to open an Edge web browser in your test in a Linux environment, you would expect it to work (or say that the LINUX webdriver has not been installed), not that the Windows executable is missing. In the meantime, thks for the trick.

remontees avatar Mar 10 '21 15:03 remontees

Rechecked pull request against updated unit/acceptance tests with passing results.

emanlove avatar Oct 09 '22 11:10 emanlove