add optional little_endian argument to new_protocol method. Also, pas…

[MattFriedman]

…s the value of this argument to the Protocol constructor. this gives the user of the new_protocol the ability to specify byte order when creating the protocol

This is related to the issue I created earlier. See: https://github.com/robotframework/Rammbock/issues/63

[jussimalinen]

Thanks for the pull request! We have tried to keep the documentation and tests up to date with new features when ever possible.

Could you consider also making an acceptance test for this? At the most simple form it could be a test where you define a very simple little endian protocol for server. Then client sends something in raw binary hex and server receives it so that the contents are reversed for each field?

But you could define the protocol and message format for the server there in within that test if you prefer.

The tests are in atest folder. A bit difficult to follow some of them, but you can look at for example https://github.com/robotframework/Rammbock/blob/master/atest/protocol_templates/define_protocol.robot for reference.

I can also write the test but then it will take a moment.

[MattFriedman]

Hi Jussi, thanks for the challenge to do that, but I'm sorry I'm so busy with work I won't be able to fit it in. I do appreciate your library very much and thanks, Matt

On Mon, Feb 20, 2017 at 9:04 AM Jussi Malinen [email protected] wrote:

Thanks for the pull request! We have tried to keep the documentation and tests up to date with new features when ever possible.

Could you consider also making an acceptance test for this? At the most simple form it could be a test where you define a very simple little endian protocol for server. Then client sends something in raw binary hex and server receives it so that the contents are reversed for each field?

But you could define the protocol and message format for the server there in within that test if you prefer.

The tests are in atest folder. A bit difficult to follow some of them, but you can look at for example https://github.com/robotframework/Rammbock/blob/master/atest/protocol_templates/define_protocol.robot for reference.

I can also write the test but then it will take a moment.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/robotframework/Rammbock/pull/64#issuecomment-281087383, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPRMO0ODadLoO2bSYgee3Z3SX3nJLwlks5reZ2AgaJpZM4L-voB .