trunk-recorder
trunk-recorder copied to clipboard
Issues I'd like to (see) address(ed) #2
Having gotten back into playing/messing with trunk-recorder, this is a follow-up to #456 and is list I've been keeping/adding to myself
- [x] remove duplicate
#include <errno.h>
in lib/op25_repeater/lib/p25_frame_assembler_impl.cc - [x] "tbsk" typo in p25_parser.cc
- [ ] emergency flag (cc and calls)
- [x] create configure.md entry for logDir option
- [x] create configure.md entry for controlRetuneLimit option
- [ ] create configure.md entry for silence frames, make boolean (should do "real time" recording by including the silence frames that terminators, etc are attached to)
- [ ] fix unitScript configure.md entry (something about talkgroups?)
- [ ] remove white space at end of lines/spaces before tabs
- [ ] add pause to
create_call_json
in call concluder to wait for compress_wav to finish - [x] remove duplicate add_file_log (fix #754), move it up so "Using Config file"..."Log Directory" lines make it into them
- [x] option to disable BOOST logging to console (since there's also the log files option)
- [ ] make priority levels work more logical (e.g. allow preemption when a lower-numbered priority call comes in and there's no recorder available, have a level setting above which talk groups are never recorded)
- [ ] have a priority level setting that is given to unknown talkgroups, instead of just the blanket record/ignore option
- [ ] add line break to chan update log messages (issue is that a single update message can contain 2 entries)
- [ ] possibly add
message.source == call->talkgroup
checking 0eb05cdeede051881f41adecbf063606734206fe - [ ] possibly add TG/freq == 0 checking bbbaa6ca07dc8e47ea498ca1b9b06c687ed209d9 (but like 55cc8b04a8ed47ef92a1c24bdbc23848c441bacb instead; I'm getting calls for 769.000000; is that a valid frequency on any system?)
- [ ]
BOOST_LOG_TRIVIAL(info) << "stopping flow graph" << std::endl;
(?) - [ ] move unknown message logging from p25_parser to main so the system name can be added (or is there a way to get the system name in p25_parser? Right now all of those messages don't include where they came from)
- [ ] add a flag to log lines that are control channel messages (not about calls or other trunk-recorder actions)
- [x] combine channel grant and update routines
- [ ] move patch info logging from rate check to status message (it creates repetitive log lines every 3 seconds now)
- [x] debug log newly seen patches https://github.com/rosecitytransit/trunk-recorder/commit/0c1610e9a28d221608239668e6bd993725a31963
- [ ] only do
add_internal_plugin
if plugin is set in config.json - [ ] remove the freqList line from JSON creation (see #794)
- [ ] possibly remove the talkgroup_tag / _description / _group_tag / _group lines from JSON as consumers should be looking that stuff up in the channel list.
- [ ] remove
rx_status.last_update
that I added as I don't use it anymore - [x] change default for callLog option in code https://github.com/robotastic/trunk-recorder/blob/0dbe2f3e3974b3e959394452f7fec808e7d0f470/trunk-recorder/main.cc#L334 to match the
false
stated in configure.md - [ ] perhaps make USRP support optional ( 031ffcc )
- [ ] possibly a tiny version of trunk-recorder with all call functions removed, for testing location/device/settings/antenna quality based on control channel decoding rate
- [ ] possibly implement maxDuration for trunked calls (only does conventional now; would stop stuck calls)