Umang G. Patel comments

Results 20 comments of


                                            Umang G. Patel

Pass remove lifecycle hook to config.onRemove

Hi @MohitKS5, Please Resolve the conflicts and change version in package.json again

Temporary resolutions of XSS problem

hey @neSpecc, Pls check and let me know when to merge.

Allow error message to be display in notice

Hey @mpandzo can you pls provide the access to your fork so I can update the PR.

Parameterized Query inside the `datetime` function

@dougnazar Thanks for the solution. My doubts are resolved. @SRombauts Pls let me know if you are planning for these enhancements.

Incorrect yandex-music-track url parser

@neSpecc can you check this I am not familiar with Yandex

Incorrect yandex-music-track url parser

Hi @DragorWW, Can you please update the same regex inside the test case inside [service.js](https://github.com/editor-js/embed/blob/master/test/services.js)

Adding unit support for dimensions

@sos-productions Can you please check the width and height functionality because isn't working ?

Add compatability with @editorjs/list data format

@cam-perry, Thanks for PR. Please update your PR or give us access to your fork so we can complete this PR.

Update image in readme

PR also include #209

Update images in readme

@talyguryn can we close this PR because images in this PR is not good