helmfile icon indicating copy to clipboard operation
helmfile copied to clipboard

Helm v3 ability to pass --history-max argument on the release level

Open zen4ever opened this issue 6 years ago • 4 comments

Helm v3 has an argument

--history-max int          limit the maximum number of revisions saved per release. Use 0 for no limit.

but it doesn't seem like there is a way to pass it. I've tried to pass it via

helmDefaults:
  args:
    - --history-max
    - 5

It works for upgrade command, but "helm list" command fails with

Listing releases matching ^ingx$
exec: helm list --filter ^ingx$ --history-max 5
exec: helm list --filter ^ingx$ --history-max 5:
getting deployed release version failed:helm exited with status 1:
  Error: unknown flag: --history-max
worker 2/2 finished

Ideally, there will be a variable "historyMax" on the release level.

zen4ever avatar Sep 20 '19 03:09 zen4ever

I agree. historyMax on release level would be awesome. I'm willing to implement this.

nauxliu avatar Dec 10 '19 08:12 nauxliu

@nauxliu @mumoshu after this change the helm environment variable HELM_MAX_HISTORY is not working

abrarcv170 avatar Aug 23 '22 13:08 abrarcv170

see: https://github.com/roboll/helmfile/issues/2148

yxxhero avatar Aug 23 '22 14:08 yxxhero