supervision icon indicating copy to clipboard operation
supervision copied to clipboard

[IconAnnotator] - mark objects with custom icons / images

Open SkalskiP opened this issue 1 year ago • 12 comments

Description

Create IconAnnotator - whose task is to mark objects related to sv.Detections with custom icons.

273726799-6b0ea345-bb22-4c3d-9e67-6a91371f852e

It should also allow you to control the icon position in relation to the box using sv.Position.

API

class IconAnnotator(BaseAnnotator):

    def __init__(
        self,
        icon_path: str,
        position: Position = Position.TOP_CENTER
    ):
        pass

    def annotate(
        self,
        scene: np.ndarray,
        detections: Detections,
    ) -> np.ndarray:
        pass

Additional

  • Note: Please share a Google Colab with minimal code to test the new feature. We know it's additional work, but it will definitely speed up the review process. Each change must be tested by the reviewer. Setting up a local environment to do this is time-consuming. Please ensure that Google Colab can be accessed without any issues (make it public). Thank you! 🙏🏻

SkalskiP avatar Oct 12 '23 12:10 SkalskiP

@SkalskiP I'm interested in working on this one.

Rajarshi-Misra avatar Oct 12 '23 14:10 Rajarshi-Misra

@Rajarshi-Misra you are assigned!

SkalskiP avatar Oct 12 '23 14:10 SkalskiP

@SkalskiP Is this still available ? I would be glad to contribute to this. :)

Shishuii avatar Nov 03 '23 14:11 Shishuii

@Shishuii I am re-assigning to you. You can start working on it.

onuralpszr avatar Nov 03 '23 21:11 onuralpszr

Hi @onuralpszr , Below is the final output of IconAnnotator. (I have added the box annotations just for visualization) Shall I submit a PR for review? final_ouput_v2

Shishuii avatar Nov 05 '23 17:11 Shishuii

@Shishuii looking nice do please PR let's talk about on PR as well.

onuralpszr avatar Nov 05 '23 17:11 onuralpszr

Hi @onuralpszr , Please review the PR. The PR can be tested on this colab link : https://colab.research.google.com/drive/1rjwO76QwA-W5WhA0Tvy3uSFtmCtbd9rA?usp=sharing

Shishuii avatar Nov 06 '23 08:11 Shishuii

@SkalskiP I'd like to take this (based on the work in https://github.com/roboflow/supervision/pull/579).

dfreilich avatar Feb 18 '24 17:02 dfreilich

Hi @dfreilich 👋🏻 ! I'm very sorry for the late response. I was a bit busy with other duties. I'm looking at your PR now.

SkalskiP avatar Feb 21 '24 20:02 SkalskiP

@SkalskiP I want to contribute for this issue

arpit2167407 avatar Jul 09 '24 17:07 arpit2167407

Hi @arpit2167407 👋

We're a bit behind with reviewing user submissions at the moment. As it stands, there's a PR for this already, so I wouldn't encourage new contributions.

LinasKo avatar Jul 10 '24 08:07 LinasKo

Ok thanks,

Arpit

On Wed, 10 Jul 2024, 14:20 Linas Kondrackis, @.***> wrote:

Hi @arpit2167407 https://github.com/arpit2167407 👋

We're a bit behind with reviewing user submissions at the moment. As it stands, there's a PR for this already, so I wouldn't encourage new contributions.

— Reply to this email directly, view it on GitHub https://github.com/roboflow/supervision/issues/460#issuecomment-2219931123, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY4SVM3QDIR6RMZOZMJOJNLZLTYWRAVCNFSM6AAAAAA55RETBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJZHEZTCMJSGM . You are receiving this because you were mentioned.Message ID: @.***>

arpit2167407 avatar Jul 10 '24 09:07 arpit2167407