supervision icon indicating copy to clipboard operation
supervision copied to clipboard

Replaces github hosted images to roboflow hosting

Open joaomarcoscrs opened this issue 1 year ago • 2 comments

Description

Changes some image links in the SAHI cookbook to use roboflow's image storage. It was breaking:

image image

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)

How has this change been tested, please provide a testcase or example of how you tested the change?

Go to the documentation page of the SAHI Cookbook and see that it gets no error rendering the images there.

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.

Docs

  • [x] Docs updated?

joaomarcoscrs avatar Oct 10 '24 19:10 joaomarcoscrs

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com. If commits are added to the pull request, synchronize your local branch: git pull origin joao/fix/sahi-cookbook-images-from-cdn

github-actions[bot] avatar Oct 10 '24 19:10 github-actions[bot]

Thanks @joaomarcoscrs!

I'll get it merged tomorrow morning!

LinasKo avatar Oct 10 '24 19:10 LinasKo

@LinasKo I checked all pictures and all looks in placed and based on that I merging in. @joaomarcoscrs thank you for uploading and fixing those links

onuralpszr avatar Oct 11 '24 11:10 onuralpszr