roboflow-python icon indicating copy to clipboard operation
roboflow-python copied to clipboard

Update/chardet package version (issue #195)

Open DarianAltF4 opened this issue 2 years ago • 3 comments
trafficstars

Description

Please include a summary of the change and which issue is fixed or implemented. Please also include relevant motivation and context (e.g. links, docs, tickets etc.).

Updated the chardet package from version 4.0.0 to version 5.0.0 in response to issue #195. The original request sought an upgrade to version 5.2, but this would have necessitated users to have Python version 3.7, while the current documentation recommends Python 3.6 and above. Version 5.0.0 of chardet is the highest available upgrade that maintains compatibility with Python 3.6+.

Type of change

  • [ ] Package update

How has this change been tested, please provide a testcase or example of how you tested the change?

Yes. All unit tests passed.

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc. No.

Docs

  • [ ] Docs updated? What were the changes:

DarianAltF4 avatar Oct 20 '23 04:10 DarianAltF4

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 04 '23 01:11 CLAassistant

Can we use 5.2.0?

capjamesg avatar Dec 19 '23 15:12 capjamesg

I opened an alternative to this PR at #230 that bumps chardet all the way up to the current version 5.2.0. This is now possible due to the fact that this project has since moved on to python>=3.8

telamonian avatar Feb 23 '24 20:02 telamonian

I am going to close this in favour of #230. Please follow #230 for updates.

capjamesg avatar Jun 20 '24 09:06 capjamesg