Rob Norris

Results 294 comments of Rob Norris

@elizagamedev apart from the two outstanding comments above, I believe this is done!

> * Run rustfmt again after further changes. I ought to make this a pre-merge Github actions check or something. `cargo fmt` is running clean for me; did you spot...

> By the way, once this is merged and once I finish fixing #26 (I've done about half of it) I'm planning on releasing v2.1 in response to the bearer...

> By the way, once this is merged and once I finish fixing #26 (I've done about half of it) I'm planning on releasing v2.1 in response to the bearer...

> I know some software depends on the cur/new/tmp setup. I thought that mutt was one of them, but maybe that's not the case with the notmuch backend. I'm not...

> I still don't see the latest update addressing my comment from chat, so I'll leave it here to not forget: Make sure this will not propagate ENOTSUP errors. They...

> Maybe I missed it, but can you add a link to the follow-up PR? @tonyhutter sorry, not posted yet. During final testing it kept running into #14872, and because...

> Can you take a look and let us know they're related to this PR or not? @tonyhutter All these tests, I think, relate to or use pool discovery in...

Rebased to master. I believe its correct, but as noted, results in an unnecessary ZIL performance regression when the pool is degraded but still operational. #16375 was my intended fix...