Rob Murray

Results 211 comments of Rob Murray

Oh, for the lint failures - the integration-cli functions can be removed if they're unused ... ``` integration-cli/docker_api_network_test.go:198:6: func connectNetwork is unused (unused) func connectNetwork(t *testing.T, nid, cid string) {...

> I was curious if this was something specific to how kubernetes patches these files behind dockerd's back, but it looks like something may indeed regressed; at least I think...

> I don't think it's a regression, at-least not a recent one ... v25 did the same - the .hash file is only checked before updating resolv.conf (to set up...

> With the proposed fix, that won't happen. So, it could be a breaking change - for example, someone who shuts down a laptop at work, brings it home and...

Hi @thespirit61 - the important part of the error message is `failed to start docker-proxy, check that the current version is in your $PATH` ... The moby 28.x version of...

Yes, the new version of `docker-proxy` would normally be installed along with `dockerd` (although you've not mentioned what OS you're using, or how you installed docker). But, even if the...

Oh, there's a merge conflict now (and, nit - a blank line at the end of the test).

Sorry for the delay ... looks like the rebase went wrong though - `TestAPIImagesSaveAndLoad` is back (you removed it in https://github.com/moby/moby/pull/51559).

It'd be great to know more about this so we can investigate. An example compose file that reproduces the issue would be ideal. Otherwise - inspect outputs for containers and...