polar-3gpp-matlab icon indicating copy to clipboard operation
polar-3gpp-matlab copied to clipboard

Published 20 hours ago • verified publisher icon robmaunder

A little suggestion about the code

Open Nineteen-Hundred opened this issue 5 years ago • 3 comments

When I directly call the PUCCH_encoder.m and PUCCH_decoder.m, only 15 (32,16) polar blocks can be encoded or decoded per second. After reading the code, I have found an interesting point that the path 'component' will be added every time the encoding and decoding function is called. After moving the corresponding codes to top file to make them be called only once, the speed can be improved by up to 100 times (about 2000 blocks per second). So, I think this may be taken into consideration in your future revision.

Nineteen-Hundred avatar May 24 '19 02:05 Nineteen-Hundred

Thanks for this excellent suggestion! I will incorporate it into a future version.

robmaunder avatar May 29 '19 21:05 robmaunder

@robmaunder If folder 'components' is renamed to 'private', then all the instances of addpath 'components' in the code can be removed.

zpan008 avatar Feb 23 '22 14:02 zpan008

@robmaunder If folder 'components' is renamed to 'private', then all the instances of addpath 'components' in the code can be removed.

Another excellent suggestion! I will incorporate it into a future version.

robmaunder avatar Feb 23 '22 16:02 robmaunder