Robin Cole
Robin Cole
@adam I also tried `torchmetrics==1.1.0` and got the failures, but didn't dig into it
@adamjstewart have dropped the `on_epoch/on_step` modifications from this MR. It feels manageable to me now, but can split further if required
@adamjstewart I'm inclined to close this PR as I don't feel confident I understand the behaviour of torchmetrics in this implementation. Elsewhere I am using the on_stage_epoch_end hooks and feel...
torchmetrics=1.1.0 test errors [here](https://github.com/microsoft/torchgeo/actions/runs/10286260844/job/28466487135?pr=2130) ``` MeanAveragePrecision(), kwargs = {'average': 'macro'} ... ValueError: Unexpected keyword arguments: `average` ``` See this was [added in 1.1.1](https://github.com/Lightning-AI/torchmetrics/releases/tag/v1.1.1)
After discussion with torchmetrics devs, created https://github.com/Lightning-AI/torchmetrics/issues/2683
I believe Lightning offers tools for profiling
@adamjstewart @DimitrisMantas per this comment we should be using the `_epoch_end` hooks https://github.com/Lightning-AI/torchmetrics/issues/2683#issuecomment-2331146337
In addition to class wise or instead of? I think that would be nice to have the complete set - with the classwise as optional otherwise the list of metrics...
Awaiting https://github.com/microsoft/torchgeo/pull/1978
Very welcome to create a pull request