fsviewer icon indicating copy to clipboard operation
fsviewer copied to clipboard

macOS: Crash when opening folder with subfolder called "Öffentlich"

Open roblillack opened this issue 11 months ago • 1 comments

roblillack avatar Dec 04 '24 21:12 roblillack

This seems to happen, because a custom Icon is searched for every file/dir name, stack:

  • char* GetFileImgName(char* fileName, enum FileType fileType) in files.c
  • char* FSGetStringForNameKey(char* name, char* key) in prop.c
  • WMPropList* FSGetUDObjectForKey(WMUserDefaults* database, char* defaultName) in prop.c
  • WMPropList* WMGetUDObjectForKey(WMUserDefaults *database, const char *defaultName) (in WINGs/WUtil)

There seems to be an issue with hashing UTF-8 keys in this function. The real fix is twofold: Fix the hash function in WINGs and make sure FSViewer does not try to load userdefaults for every file entry. I'll fix the latter here, it will probably still show up for files that contain umlauts in the extension ....

roblillack avatar Dec 04 '24 21:12 roblillack