Alec L. Robitaille comments

Results 29 comments of


                                            Alec L. Robitaille

rredlist: 'IUCN' Red List Client

@ropensci-review-bot assign @stephhazlitt as reviewer

rredlist: 'IUCN' Red List Client

Thanks to both @stephhazlitt and @KevCaz for agreeing to review {rredlist}! Please let me know if you need anything as you work on your review.

rredlist: 'IUCN' Red List Client

Thank you @KevCaz for your review. Just a minor note, I see under "Could have" / "tests" two paragraphs with a few repeated sentences. When you have a moment, can...

rredlist: 'IUCN' Red List Client

@ropensci-review-bot submit review https://github.com/ropensci/software-review/issues/663#issuecomment-2465103921 time 7

rredlist: 'IUCN' Red List Client

@ropensci-review-bot submit review https://github.com/ropensci/software-review/issues/663#issuecomment-2465103921 time 7

Calculation of distance with NA in X and/or Y coordinates

Thanks @paleolimbot - let me know how I can help.

Calculation of distance with NA in X and/or Y coordinates

Thanks @edzer A related case, though involves the user actively setting na.fail to FALSE in `st_as_sf`, we see: ``` r # With # remotes::install_github('r-spatial/sf@34d4aba90763b87397f393c75a45aa4c811c04d7') library(sf) #> Linking to GEOS 3.13.1,...

Calculation of distance with NA in X and/or Y coordinates

Great, this looks like it makes the handling of NAs more consistent, across all methods in `st_distance` and other downstream functions ``` r library(sf) #> Linking to GEOS 3.13.1, GDAL...

Calculation of distance with NA in X and/or Y coordinates

Not related to the issue of returning POINT EMPTY or an error (let me know if I should open this as a separate issue in sf), but another difference in...