fela icon indicating copy to clipboard operation
fela copied to clipboard

Typescript interface for renderer configuration (IConfig) misses some options

Open AvalonCV opened this issue 2 years ago • 1 comments

Type: Feature

Packages Version
fela 12.x.x

Description

Hello,

the documentation for "Renderer Configuration" https://fela.js.org/docs/latest/advanced/renderer-configuration includes the following options

  • optimizeCaching
  • styleNodeAttributes
  • propertyPriority

that are currently not part of the IConfig interface in fela/index.d.ts

Proposal

Add the missing options to the interface - maybe like:

Code Example:

  interface IConfig {
    ...
    optimizeCaching?: boolean
    styleNodeAttributes?: { [key: string]: string }
    propertyPriority?: : { [key: string]: number}
  }

?

Thanks and have a nice day :)

AvalonCV avatar Jul 12 '22 10:07 AvalonCV

The code looks good to me! Would you be open to send a PR with these changes?

robinweser avatar Jul 13 '22 13:07 robinweser

@robinweser his PR is up

marwan38 avatar Nov 01 '22 19:11 marwan38