swolebot icon indicating copy to clipboard operation
swolebot copied to clipboard

Fixed most of the issues and also adds much more fun!

Open jutaz opened this issue 10 years ago • 5 comments

So this PR implements #7, #4, #5, #1, #2.

Fixes pluralization issues, and add fun! Now messages might looks like this: screen shot 2015-01-18 at 12 19 52 am

jutaz avatar Jan 17 '15 22:01 jutaz

This is a pretty cool update. A couple thoughts, though:

  • Randomizing takes some of the fun out of it. I like that the amounts are entirely based on the amount of open PRs.
  • The random messages is a great idea, though some are a little silly. eg. "Sweat away those pounds." is fine, but "With :heart: from :moon:" is a little strange. I'm not sure I like that random people can be singled out either, because it takes away from the solidarity of the whole thing.
  • Multiple exercises sorta complicates things, or turns it into too much of a workout. What's default behavior and what's configurable?

brianmuse avatar Jan 20 '15 17:01 brianmuse

  • Randomizing is only done to distribute amount PR`s to exercises. This does not add or remove anything.
  • Agree. Just wanted more messages to start off. This needs some :heart: from our poets /cc @zachdunn
  • This is the default behavior. Everything is configurable. Number of exercises, types of exercises, ratios, and so on.

jutaz avatar Jan 20 '15 17:01 jutaz

:+1: for pushups, i want that unbalanced no-leg-day thing everyone seems to be doin!

atticoos avatar Jan 20 '15 17:01 atticoos

@robinpowered/product-team Merge PLS, this adds double pushups for us

jutaz avatar May 19 '15 07:05 jutaz

Not to speak for too many, but I know that most of the people that do the pushups together in the office simply do a 1-to-1 on the number of open pull requests (25 pushups for 25 PRs, regardless of PR age). Is there any way we can make the non-linear pushup calculation (and old count) an option?

Rican7 avatar May 27 '15 15:05 Rican7