glamorous-native icon indicating copy to clipboard operation
glamorous-native copied to clipboard

Fix RN typing breaking change: ViewProperties => ViewProps

Open slorber opened this issue 6 years ago β€’ 3 comments

The RN typings have a breaking change for a few versions now.

All types like "ViewProperties" are now "ViewProps".

The following:

import { ViewProperties } from 'react-native' must be replaced by import { ViewProps } from 'react-native'

I don't know exactly when this breaking change happened but it's already been a while it seems. It would be cool to publish a new version with this fix.

I've found this that seems to try to bring retrocompatibility somehow, but not sure how it's supposed to be used: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native/legacy-properties.d.ts

slorber avatar Dec 05 '19 14:12 slorber

Codecov Report

Merging #113 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files          12       12           
  Lines         145      145           
  Branches       43       43           
=======================================
  Hits          133      133           
  Misses          8        8           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 332b09a...4f98252. Read the comment docs.

codecov-io avatar Dec 05 '19 14:12 codecov-io

Seems to have been renamed since 2018: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/25307

So it should be safe to merge now in v2 or v3

slorber avatar Dec 05 '19 14:12 slorber

Hi @ajwhite , what do you think of this PR?

slorber avatar Jan 23 '20 18:01 slorber