More precise return type of `Exitter::exit()`

Open jdreesen opened this issue 2 years ago • 2 comments

PHP 8.1 allows us to use a more precise return type for Exitter::exit(): never

Apr 25 '23 22:04 jdreesen

@jdreesen Currently the test suite fails on this because of https://github.com/sebastianbergmann/phpunit/issues/5048 So until that one lands I won't be able to merge I think. Suggestions?

Apr 26 '23 07:04 robiningelbrecht

Oh, I see. I wasn't aware of this limitation. Then I guess we'll have to wait...

Apr 26 '23 08:04 jdreesen

Phpunit maintainer won't "fix" this... not much we can do

Aug 27 '24 11:08 robiningelbrecht