faust icon indicating copy to clipboard operation
faust copied to clipboard

Fix mypy error for field_for_type function. Fixes #672

Open forsberg opened this issue 5 years ago • 3 comments

Description

An attempt to fix #672. I'm not all that experienced in using mypy/typing in Python, so there may be better ways.

#type: ignore is also an option, I guess.

forsberg avatar Oct 20 '20 08:10 forsberg

Codecov Report

Merging #673 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #673   +/-   ##
=======================================
  Coverage   98.32%   98.32%           
=======================================
  Files          99       99           
  Lines       10193    10195    +2     
  Branches     1139     1139           
=======================================
+ Hits        10022    10024    +2     
  Misses        138      138           
  Partials       33       33           
Impacted Files Coverage Δ
faust/models/fields.py 97.26% <100.00%> (+<0.01%) :arrow_up:
faust/models/record.py 96.39% <100.00%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 01b4c0a...12626a6. Read the comment docs.

codecov-io avatar Oct 20 '20 10:10 codecov-io

any progress on getting this pushed through? it could be nice to get venusian upgraded

camerondavison avatar Feb 19 '21 17:02 camerondavison

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Erik Forsberg seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 21 '21 07:09 CLAassistant