faust icon indicating copy to clipboard operation
faust copied to clipboard

added take_events() function

Open itsmesrds opened this issue 5 years ago • 3 comments

Description

This PR adds a new function stream.take_events() which will return events()

https://github.com/robinhood/faust/issues/660 (Fixes #660)

itsmesrds avatar Sep 27 '20 12:09 itsmesrds

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

:x: sivasai-quartic
:x: itsmesrds
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 03 '20 12:10 CLAassistant

Since returning events is a requirement for manual acknowledgment, how about we include the "fix" for noack-streams as well?

I linked the bug in the feature request for this and here would be a code example of take with consideration for noack https://gist.github.com/fr-ser/347c00e0026cd7941e1d73fd36e54887

fr-ser avatar Oct 11 '20 08:10 fr-ser

As a user of Faust, I would also like this PR to be approved/merged. The take_events functionality is super useful.

qbzenker avatar Jan 05 '21 20:01 qbzenker