Standardise language used to describe Warriors, Heroes and Villains.

[sparksp]

The terms "Warrior" and "Player" seem to be used interchangeably - although when you see "Player" alongside "PC" and especially "NPC" you might expect Player to mean PC and not NPC. When you then read "advancing players" you might then think they are only PCs, but is in fact any Warrior. Once it is understood that a "Player" is used to refer to any Warrior then that all makes some sense - but I think it could be cleared up by using "Warrior" instead of "Player" in many places (e.g. advancing warriors).

However, when we look at the internal Map module there is a list of NPCs that in fact contains all active Warriors, not just the Non-Player Warriors. I suspect this is came from copying the Builder interface onto Map, where it makes sense to list only the NPCs on the template. This should also be changed to be "setWarriors" and a list of "Warriors".

There's also a concept of "Hero" and "Villain" used briefly in the internals but PC and NPC seem to be preferred the closer to Program.elm you get (or the further away from Warrior's internals).

I propose using "Warrior" to describe any Warrior (Hero or Villain), "Hero" for any user provided Warrior and "Villain" for any built-in Warrior; and removing all other references to "PC" or "NPC". This would mean Map Templates would have a list of "villains" (not "npcs") and Maps would have a list of "warriors".

[robinheghan]

Agreed.

PR is welcome if you have the time and energy.