elm-git-install icon indicating copy to clipboard operation
elm-git-install copied to clipboard

Add elm-deps as dependencies

Open robinheghan opened this issue 5 years ago • 7 comments

Git deps might have direct and indirect dependencies which aren't git-dependencies. These should be added to the right places in the application's elm.json.

Not entirely sure how this should work. Do we clone the repos and read their tags, scrape package.elm-lang.org? Needs investigating.

robinheghan avatar Sep 03 '18 20:09 robinheghan

I ran into an issue where I installed a git-dependency but my app failed to compile due to missing all the dependencies for that package. At first I thought this was a bug but if I understand correctly that's what this issue is referring too?

MartinSStewart avatar Apr 09 '20 19:04 MartinSStewart

@MartinSStewart Yes. Not sure how to best approach this issue. I don't think elm install supports specifying a version range, if it did it would be a simple matter of iterating through all dependencies in elm.json and calling elm install on them 🤷‍♂️

robinheghan avatar Apr 14 '20 08:04 robinheghan

What about using elm-json instead?

MartinSStewart avatar Apr 14 '20 08:04 MartinSStewart

That could work. I do have limited capacity at the moment however. A PR would be much appreciated if you have the time.

robinheghan avatar Apr 14 '20 08:04 robinheghan

I can take a look later today and see if it's something I can puzzle out.

MartinSStewart avatar Apr 14 '20 08:04 MartinSStewart

Awesome!

robinheghan avatar Apr 14 '20 08:04 robinheghan

Sorry, I won't have time to do this either. Maybe someone else can implement this or maybe I'll give it a shot at a later date.

MartinSStewart avatar Apr 14 '20 16:04 MartinSStewart