flac2mp3 icon indicating copy to clipboard operation
flac2mp3 copied to clipboard

Tag conflict causes tags to always be rewritten

Open djjeck opened this issue 10 years ago • 3 comments

I noticed that when ALBUMARTIST tag is set, but not BAND, since they are both mapped to the same key (TPE2), they overwrite each other, causing the tag matching to fail and the tags to be rewritten on subsequent re-runs. This is not always the case, but it looks like it happens with 50% probability. It looks like no precedence is declared between the two, so I guess it depends on how python iterates the map structures involved. (A similar thing happens for the COMMENT tag, but I believe it happens because of a multiple comment field that I will manually fix. This is much rarer, just one album on my collection. I'm not sure the file is well-formed, so I won't open another ticket)

Workaround: get rid of the BAND tag. I actually remember that ALBUMARTIST was commented out some time ago, possibly for this reason. But if one needs to go, I'd take BAND out. Replacing

'BAND'                    => 'TPE2',

with

'BAND'                    => 'TXXX',

stops the tag rewrites from happening.

I will try to implement a better fix, with no indeterminacy nor information loss involved, and update this thread.

djjeck avatar Jan 05 '15 01:01 djjeck

Did you come up with a better fix ? I've just run into this issue.

andynormancx avatar Jun 19 '15 05:06 andynormancx

Fix works. Thx!

TheGoblinHero avatar Nov 21 '16 13:11 TheGoblinHero

Yeah I just commented out that line completely. I've never seen a BAND tag used anyway.

trip5 avatar Dec 31 '19 13:12 trip5