Robert Pasiński

Results 28 comments of Robert Pasiński

Hey, @lovegaoshi I've tested your repro on React Native `0.75.3` and it seems to be working well with this fix applied https://github.com/doublesymmetry/react-native-track-player/pull/2290 I did not use the exact changes from...

Hey, I've checked it again and yeah, I missed the events. 😅 I've set up two PRs that should fix the issue (on both React Native and RNTP): - https://github.com/doublesymmetry/react-native-track-player/pull/2370...

> omg tysm! at a short glance everything seems to be in order. I do see the old arch now breaks - [bc the old arch's appregistry related code is...

> > ofc I need to test this heavily in prod, but unrelated, what are the chances these changes can be included in RN 0.76? cc @cortinico > > As...

@cortinico I'll be testing it today as it should work on both archs

I believe I tested it thoroughly and it works on both platforms. @lovegaoshi are you sure you rebuilt it from source and that the patches were not overriden? I retested...

> @robik [My repo's patch](https://github.com/lovegaoshi/RNTPExampleNewArch/blob/830428365aac927e2f3c984fe414469b6d4c88af/patches/react-native%2B0.75.3.patch#L18) didnt delete [this line](https://github.com/facebook/react-native/pull/46480/files#diff-002ea34c79a5a26a976b6a9aceadbf27d2f658202c55cc561daab1df4c247009L366) from #46480 (where the else handled the old arch AppRegistry), so it works on both architecture; if you delete that line...