tcr icon indicating copy to clipboard operation
tcr copied to clipboard

Propagates positional and keyword arguments to the real_tcp method

Open agustin opened this issue 1 year ago • 1 comments

Because the tcp method on the Socket class also accept some keyword arguments, we need to properly forward those to the real_tcp call. Another option will be to directly remove all other optional args from the call.

The error that was raised was TypeError: no implicit conversion of Hash into String

agustin avatar Jun 04 '24 10:06 agustin

I just notice that there was a PR that already commented on this https://github.com/SalesLoft/tcr/pull/38#issuecomment-1076393095

agustin avatar Jun 04 '24 14:06 agustin

@sionide21 Could you please review and merge this?

Thank you!

Laykou avatar Nov 11 '24 08:11 Laykou