Rob Falck comments

Results 45 comments of


                                            Rob Falck

several dymos components are doing unnecessary unit conversions

This is a holdover from the days before OpenMDAO supported unit conversion on constraints and objectives. We can get rid of it now.

convergence issues of nonlinear solver when under FD

If you could find the time to provide some code for a test case/example of this capability, it would help us to implement it.

Added `usedforsecurity=False` flag to hashlib.md5 uses for FIPS-enabled systems.

@andrewellis55 it's fairly easy to accommodate 3.8 here so I'll make the change. Out of curiosity, what's blocking you from upgrading to 3.9 or later?

Exception thrown using recording manager on Linux computer with FIPS

Thanks for the issue. Python 3.8 reaches end of life in a few months anyway, so I think we'll probably just set the oldest supported openmdao to 3.9 and add...

Exception thrown using recording manager on Linux computer with FIPS

It was an easy fix and you gave us all the information we needed in the issue, thank you!

added zero_tol parameter for check_partials method

Thanks for your contribution! Would you be able to add a test for our CI that verifies that this works? It can be as simple as capturing the text from...

added zero_tol parameter for check_partials method

After testing this implementation a bit, I have a few suggestions. I think `zero_tol` should specify the magnitude of the `calc_mag` below which the relative error is not calculated. A...

Implementation of POEM 096: Minimization of Constraint Violation

By all means, we'd be happy to accept this if you'd like to undertake it. Post an issue on github and then assign it to yourself. (If you find yourself...

`check_partials` not working as intended with sparse partials

I think that's the right way to do it. Check if Val is a sparse array and convert as necessary, otherwise use rows and cols and assume it's COO

Auto-Prune Constraints with None as the Upper and Lower Bound

I'm of a mind that any constraint where `upper`, `lower`, and `equals` are all None, then the constraint should just be ignored. I can't think of a valid reason to...