easygui icon indicating copy to clipboard operation
easygui copied to clipboard

Version 0.98 is showing dialog message in a text box

Open rbalik opened this issue 8 years ago • 10 comments

This is version 0.97.4: image

This is version 0.98 pulled from github image

rbalik avatar Jun 29 '16 16:06 rbalik

Just installed 0.98 via pip and confirmed that the issue exists in there as well.

rbalik avatar Jun 30 '16 18:06 rbalik

Confirmed on Windows and Ubuntu. It appears this was part of a major change to the box code. Where the message field used to be a tk.Message widget, but has been replaced with a tk.Text widget with the state disabled instead.

It may be possible to change the background and border options on the Text widget to match the rest of the window. However, the defaults for all widget backgrounds are system-specific.

I couldn't seem to find any real reasoning as to why these changes occurred. This problem also exists in other boxes that previously used tk.Message and were changed to tk.Text widgets in 0.98

spyoungtech avatar Sep 23 '16 17:09 spyoungtech

@rbalik see my pull request on this for the fix.

spyoungtech avatar Sep 26 '16 15:09 spyoungtech

Hi! It was me who changed to tk.Text. Before it was impossible (for me, sorry) to control the width of the window.

https://github.com/robertlugg/easygui/commit/30bffc5f799dc5731f2b75c46e500b743a92fdd5

I could't test it for linux, though. You are right, it is ugly.

jjdenis avatar Sep 26 '16 16:09 jjdenis

Thanks for the fix. We'll try it out here.

rbalik avatar Sep 26 '16 18:09 rbalik

Hello, I'm encountering the same problem with easygui 0.98 on win-64, anaconda, installed from channel topper. Has the fix by spyoungtech been successful? Is/will it be included in version 0.99? Can/will be provided on anaconda? Thanks!

brombeerberg avatar Jan 12 '17 13:01 brombeerberg

@brombeerberg The fix for this was merged into master already and is in the current version. See #110

The topper package for easygui has not been updated since that change was made. So this change won't be reflected in that version.

The current version is on PyPI, however. You should be able to use pip to install easygui with anaconda, as far as I can tell. Alternatively, you can clone the source yourself or wait for the topper package to be updated.

Cheers.

spyoungtech avatar Jan 12 '17 16:01 spyoungtech

After "conda uninstall easygui" I could "pip install easygui" and got version 0.98.1 . Now the window text looks fine. Thanks for the hint!

brombeerberg avatar Jan 13 '17 06:01 brombeerberg

The text is better in 0.98.1 but still seems a little odd when compared to 0.97. The window has a lot more empty space and the font is different.

rbalik avatar Jan 18 '17 19:01 rbalik

So I forked and started working on a patch that moves the text in dialog boxes back to use tk.Message. This makes the text look a lot nicer and consistent across boxes, but it does have some width issues which I guess is what you guys were looking to fix in the first place. It seems like there should be a way to fix the width of dialogs without having to go to tk.Text since we're not really using that object in it's intended way and it makes things look kind of weird with the monospace font. I also tried to clean up the choicebox a bit besides just the message stuff. I think the borders were off and it was making things look weird, at least on Windows. Anyway, it's here if anyone wants to try it: https://github.com/rbalik/easygui/tree/fixchoiceboxstyle Still some boxes that aren't switched back yet but figured I'd share and see if it seems like I'm on the right track with the vision of this library before committing more time to it.

rbalik avatar Feb 22 '17 04:02 rbalik